Fix selected indication for options in high contrast mode #29707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…contrast mode Fixes that `mat-option` was showing a checkmark and a dot for selected options in high contrast mode. The dot is still necessary if the single selection indicator isn't shown.
crisbeto
added
Accessibility
crisbeto
requested review from
mmalerba and
wagnermaciel
and removed request for
a team
crisbeto
force-pushed
the
option-high-contrast
branch
from
30a3ad7
to
331d0f8
Compare
Removes some styles from the list meant for high contrast mode that we inherited from MDC. They aren't necessary, because we have our own way of handling high contrast styles and they were actively making `mat-option` worse by adding extra borders in several cases.
crisbeto
force-pushed
the
option-high-contrast
branch
from
331d0f8
to
4392f0a
Compare
wagnermaciel
approved these changes
Sep 10, 2024
crisbeto
added
action: merge
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Sep 11, 2024
Re-adds the `::before` element that was removed in angular#29707, because the removal broke some internal tests.
crisbeto
added a commit
that referenced
this pull request
Sep 11, 2024
Re-adds the `::before` element that was removed in #29707, because the removal broke some internal tests.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a couple of issues with how selected options were being shown in high contrast mode.